[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fix lt_join
From: |
Eric Blake |
Subject: |
Re: fix lt_join |
Date: |
Tue, 16 Oct 2007 07:09:26 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Ralf Wildenhues on 10/16/2007 12:04 AM:
Hi Ralf, and thanks for putting up with me...
>> Here's the implementation that mirrors what I'm installing into m4sugar;
>> it has the added benefit of being faster as well. OK to apply?
>
> OK if you can explain to me the bug. For me,
> lt_join([|],[one],,,)
>
> expands to
> one
>
> both before and after the patch.
A bug in my test environment :) I was just pasting in the definition of
lt_join, but not lt_car, in my m4sugar execution, rather than sourcing
ltsugar.m4. Obviously, if lt_car is undefined, it doesn't get expanded.
Still, once I fixed my setup, the numbers speak for themselves:
echo 'm4_debugmode(qt)lt_join(|,one,,,)' | m4 -Iautoconf/lib \
m4sugar/m4sugar.m4 ltsugar.m4 - 2>&1 | wc
pre-patch: 79 macros
post-patch: 20 macros
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHFLgG84KuGfSFAYARAjP8AJ9FC+SA3iKUU5StgBfJd1h9PBcgvQCfRHtq
0rZ8cqnomkH1h+aSWV2F0xk=
=pBo4
-----END PGP SIGNATURE-----