[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Use darwin's -force_load flag if available for whole_archive
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] Use darwin's -force_load flag if available for whole_archive_flag_spec |
Date: |
Mon, 7 Sep 2009 21:10:36 +0200 |
User-agent: |
Mutt/1.5.20 (2009-08-09) |
Hi Peter,
* Peter O'Gorman wrote on Mon, Sep 07, 2009 at 07:48:49AM CEST:
> On Sep 6, 2009, at 12:29 PM, Ralf Wildenhues wrote:
> >
> >Any reason to go with a compile test rather than a simple system
> >version test?
>
> Yes, the compile test will work when cross-compiling to darwin using
> the odcctools that I released last month (which includes the -force_load
> option).
Ah, ok. Thanks.
> This is that patch that I pushed.
One nit remaining:
> +AT_CHECK([echo quit | $LIBTOOL --mode=execute gdb main 2>err1],
> + [ignore], [ignore], [stderr])
This should not have '2>err1' any more, so that the next test is sharp.
> +AT_CHECK([grep 'Could not find object file' stderr],[1],[ignore],[ignore])
> +
> +AT_XFAIL_IF([
> +eval "`$LIBTOOL --config | $EGREP '^(whole_archive_flag_spec)='`"
> +case $whole_archive_flag_spec:$host_os in
> +:darwin*) : ;;
> +*) false ;;
> +esac ])
Thanks,
Ralf