[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes

From: Paolo Bonzini
Subject: Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes
Date: Wed, 28 Jul 2010 15:06:45 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5

On 07/28/2010 02:47 PM, Charles Wilson wrote:
On 7/28/2010 5:05 AM, Paolo Bonzini wrote:
On Wed, Jul 28, 2010 at 10:10, Charles Wilson
  But that doesn't appear to be the case for cross builds, in the
new tests.

But I don't think it was bisectable in cross builds in your original
development either.

Yes, I usually develop this way (tests are written and committed
first) and then move the tests last before the final post/push to
preserve bisectability.

Hmm. Should I pull the comments added to by
merge them into the earlier
and then reorder so that add-a-basic-sysroot-test.patch is once again last?

Yes, that's fine.

It still fails (native) new:41,101 and old:tagdemo-conf+tagdemo-make.  I
guess some more eyes on the revised 8/8 would be helpful. Well, on all
of the patches, actually, I guess -- but new 8/8 is the likely locus of
the bug.

I'd tend to blame more the libtool.m4 part.  After all it's what
computes postdeps. What about splitting it further by separating the
ltmain.m4sh (first commit) and libtool.m4 (second commit) changes?

OK. New results after the (first commit) but before the (second commit):

Interesting. In this case, old:tagdemo-conf+tagdemo-make pass, new:101
passes, but new:41 fails.

So we have two bugs now instead of one. :) On the other hand it means we can consider one change at a time, which is good news.

In particular, the sysroot patches should change nothing for native. So just comparing "./testsuite -v -d 41" output and diffing the .la files may pinpoint the cause pretty quickly. The sysroot patches are in fact relatively mechanical.

Regarding the libtool.m4, maybe squashing the (untested) attached patch could help...


Attachment: 0001-fix.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]