Re: [PATCH] libtool: LT_PATH_NM: default to ${ac_tool_prefix}nm

[Mike Frysinger]

On Sunday 28 April 2013 03:21:15 Peter Rosin wrote:
> On 2013-04-27 22:38, Mike Frysinger wrote:
> > On Saturday 27 April 2013 13:53:28 Peter Rosin wrote:
> >> On 2013-04-27 07:58, Mike Frysinger wrote:
> >>> The current code tries to locate a compatible nm tool.  It starts with
> >>> a prefixed nm tool (great!) and includes a plain nm too (that's fine).
> >>> The problem is that the code searches for the prefixed nm before the
> >>> plain nm (normally fine), but doesn't break once it has found a valid
> >>> match.  It does this so that it if it finds an "OK", but "not great",
> >>> tool, it'll keep on searching.
> >> 
> >> I agree this sounds like the wrong this to do, but isn't it better to
> >> just break all the way out when a "great" nm is found?
> > 
> > for some reason i thought the [n] arg to break wasn't portable.  this
> > should work though.
> > -mike
> 
> And on re-reading, my IFS changes are not very constructive. I removed
> those. I will push the attached in a couple of days, if there are no
> objections.

i actually thought your IFS changes made sense.  the current code 
saves/restores IFS around the inside loop, so if your code breaks out of both 
the inside and outside loop, then IFS won't get restored.
-mike

signature.asc
Description: This is a digitally signed message part.