[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2] m4: Fix interpretation of MACOSX_DEPLOYMENT_TARGET

From: Lawrence Velázquez
Subject: [PATCH v2] m4: Fix interpretation of MACOSX_DEPLOYMENT_TARGET
Date: Sat, 13 Sep 2014 13:53:37 -0400

The current template mistakenly treats a MACOSX_DEPLOYMENT_TARGET value
of "10.10" as "10.1" followed by junk. Thinking that the build is
targeting 10.1 Puma instead of 10.10 Yosemite, it tells the linker to
ignore undefined symbols instead of dynamically resolving them. This can
cause runtime crashes* and will affect subsequent versions of OS X.


Signed-off-by: Lawrence Velázquez <address@hidden>
v2: Fixed a typo in the original commit message.

Apologies if I accidentally sent multiple copies of this message.
I wasn't sure whether I had to subscribe or not to post.

 m4/libtool.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 320d8b3..068f0d8 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -1043,7 +1043,7 @@ _LT_EOF
       case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
          _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;;
-       10.[[012]]*)
+       10.[[012]][[,.]]*)
          _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined 
${wl}suppress' ;;
          _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]