Re: [PATCH] m4/libtool.m4: fix test when multilib not used by project

[Brian Inglis]

On 2024-10-21 08:38, Ileana Dumitrescu wrote:
> On 20/10/2024 22:04, Brian Inglis wrote:
> > test and config fails when projects do not use multilib
> > add usual x prefix to both sides to protect multilib test
> >
> > Fixes: ab89ebbcc2ff0ecff5157982ef03627cfd615f7e
> >
> > --- a/m4/libtool.m4    2024-10-03 06:50:08.000000000 -0600
> > +++ b/m4/libtool.m4    2024-10-19 14:09:21.384266500 -0600
> > @@ -2569,7 +2569,7 @@ cygwin* | mingw* | windows* | pw32* | ce
> >       # If user builds GCC with mulitlibs enabled,
> >       # it should just install on $(libdir)
> >       # not on $(libdir)/../bin or 32 bits dlls would override 64 bit ones.
> > -    if test yes = $multilib; then
> > +    if test xyes = x$multilib; then
> >       postinstall_cmds='base_file=`basename \$file`~
> >         dlpath=`$SHELL 2>&1 -c '\''. $dir/'\''\$base_file'\''i; echo 
> > \$dlname'\''`~
> >         dldir=$destdir/`dirname \$dlpath`~
>
> Thank you for submitting a patch! This has previously been identified
> and applied to the development branch with an additional patch also. It
> will move to master before the next stable release.
>
> https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=development&id=4cc12b83ffa947d9c1948a066c7e70c0336f6acd
> https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=development&id=3cf528a4f04e9da78b06635aac6545709007b882

That's great, thanks.
I've suggested our maintainer apply and package a release 2 incorporating this.

--
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                -- Antoine de Saint-Exupéry