Re: [Libunwind-devel] WIP patch: configurable cache size

[Milian Wolff]

Hey Arun,

sorry for the delay.

On Montag, 22. Dezember 2014 22:39:29 CEST Arun Sharma wrote:
> On Thu, Dec 11, 2014 at 7:12 PM, Milian Wolff <address@hidden> wrote:
> > On Thursday 11 December 2014 13:58:14 Milian Wolff wrote:
> >> Hey Arun,
> >>
> >> I'm still waiting for your mail you promised below ;-) Locally, I've
> >> rebased my patch on current master.
> >
> > FTR, attached you find the current state of my patch. Anything
> > missing/wrong, besides documentation?
> >
> >
> > -#define DWARF_LOG_UNW_CACHE_SIZE        7
>
> Why not retain DWARF_LOG_UNW_CACHE_SIZE and use it in a few places
> that use the constant 7?

Fixed, see attached.

> The rest of the code looks alright to me. Could you look into the make
> check failures introduced by the patch? I got 5 new failures.

The test system of libunwind is highly unreliable for me. If I change
configure flags e.g. I can trigger failures, and no way to get back to the
reliable state it was in before :-/

I just did the following in current master:

git clean -xfd .
./autogen.sh
./configure --prefix /home/milian/projects/compiled/other/ --enable-debug
make && make install && make check

and these tests fail: https://paste.kde.org/putaaf47q

Do I need to enable some special flags to get these tests to behave properly?
Note how this does not match the list of expected fails in the README for
x86-64 Linux at all...

With my branch the count does go up, and I'll try to investigate. But this
looks erratic to me :-/

Bye
--
Milian Wolff
address@hidden
http://milianw.de

0001-Make-DWARF-cache-size-configurable-via-unw_set_cache.patch
Description: Text Data

signature.asc
Description: This is a digitally signed message part.