[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Lightning] jit_pusharg_p: small bug
From: |
Ludovic Courtès |
Subject: |
[Lightning] jit_pusharg_p: small bug |
Date: |
Mon, 12 Sep 2005 09:56:03 +0200 |
User-agent: |
Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) |
Hello,
In <lightning/core-common.h>, `jit_pusharg_p' is defined as follows:
#define jit_pusharg_p(rs) jit_pusharg_ul(rs)
On IA32, `jit_pusharg_ul', once expanded, performs bitwise binary
operations (namely an `&') on its operand. Consequently, its operand
must be an integer and _not_ a pointer. If a pointer is passed, GCC
will fail with "error: invalid operands to binary &" (unlike on the
PPC).
Therefore I suggest rewriting the above macro as:
#define jit_pusharg_p(rs) jit_pusharg_ul((unsigned long)rs)
Thanks,
Ludovic.
- [Lightning] jit_pusharg_p: small bug,
Ludovic Courtès <=