|
| From: | Paolo Bonzini |
| Subject: | Re: [Lightning] [PATCH] Fix stxr_c on i386 |
| Date: | Sat, 08 Mar 2008 18:21:47 +0100 |
| User-agent: | Thunderbird 2.0.0.12 (Macintosh/20080213) |
Alban Bedel wrote:
Hi all,
I'm using lightning in a small JIT compiler and I found a little bug.
To store a char on i386 the source register must be 8bit, so when the
source is in ESI or EDI it must be moved to another register.
But currently lightning unconditionaly use EAX, this obviously can lead
to broken code if eax is used in the argument. Like this:
stxr_c eax, ebx, esi => push eax
mov esi, eax
mov al, (eax, ebx)
pop eax
Attached is a patch that fix this.
Applied, thanks!! Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |