[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lightning] Re: last "bug"

From: Paolo Bonzini
Subject: [Lightning] Re: last "bug"
Date: Wed, 11 Jun 2008 12:33:09 -0700
User-agent: Thunderbird (Macintosh/20080421)

Adr  toPatch =  jit_movi_p(JIT_R0,0x7fffffff);

which forces the emission of a 32-bit wide move. Still, I thought I'd report it as this is a robustness issue. Since the movi_p is already a variant of movi_l that returns the instruction address with the intent to patch it, maybe it would be safer/more robust to always emit an instruction of the maximum operand size.

Yes, of course.  jit_movi_p is especially meant to be patchable.

Alternatively, make separate 32/64-bit versions that use (respectively) MOVL and MOVABSQ. Thanks!

I'll wait for you to commit (remember the ChangeLog and everything) and then do this.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]