Re: [Lightning] PPC problem

[Eli Barzilay]

On Oct  9, Paolo Bonzini wrote:
> Eli Barzilay wrote:
> > 
> > The fix is in "lightning/ppc/funcs.h": subtract 1 from `end' here:
> > 
> >      end -= ((long) end - 1) & (cache_line_size - 1);
> 
> Thanks, here's what I applied:
> 
> diff --git a/lightning/ppc/funcs.h b/lightning/ppc/funcs.h
> index 9f3df90..ae9301f 100644
> --- a/lightning/ppc/funcs.h
> +++ b/lightning/ppc/funcs.h
> @@ -67,6 +67,9 @@ jit_flush_code(void *start, void *end)
>          break;
>    }
> 
> +  /* Point end to the last byte being flushed.  */
> +  end   =(void*)( (long)(end - 1));
> +
>    start =(void*)( (long)start - (((long) start) & (cache_line_size - 1)));
>    end   =(void*)( (long)end   - (((long) end) & (cache_line_size - 1)));

Hmm, we have:

  start -= ((long) start) & (cache_line_size - 1);
  end -= ((long) end - 1) & (cache_line_size - 1);

which is different.  (I'm not too familiar with this code, so I'm
CCing Matthew too, in case there is something wrong in our version of
the file.)

-- 
          ((lambda (x) (x x)) (lambda (x) (x x)))          Eli Barzilay:
                  http://www.barzilay.org/                 Maze is Life!