lightning
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lightning] Re: PATCH - Correct comparison of float branch test on i386

From: Paolo Bonzini
Subject: [Lightning] Re: PATCH - Correct comparison of float branch test on i386
Date: Thu, 19 Aug 2010 09:49:19 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5 
On 08/18/2010 09:15 PM, Paulo César Pereira de Andrade wrote:

   Now, changing it to
#define FLOAT_BRANCH_WORKS      1
I get a problem in x86_64... The attached patch is somewhat simple
minded, and just a suggestion of possible way to correct the issue.
Since the macros UCOMISSrr and UCOMISDrr are called in other places,
and some of the float branch test macros have a longer body, I added
jit_fp_btest receiving only one argument.

   With this change, it now works correctly in x86_64 also, with either
approach to branch on float compare.

   Please review.


Thanks, looks good, but I inlined jit_fp_btest inside every use instead.

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]