[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lightning] [PATCH v2] Fix 9 tests on Windows x64, due to size of lo
From: |
Paulo César Pereira de Andrade |
Subject: |
Re: [Lightning] [PATCH v2] Fix 9 tests on Windows x64, due to size of long |
Date: |
Fri, 4 Oct 2019 14:40:38 -0300 |
Em qui, 3 de out de 2019 às 17:56, Zachary Cook
<address@hidden> escreveu:
[...]
>> Just pushed an alternate patch to use jit_word_t instead of long.
>> Please check. But there might be issues with literals, that would need
>> a 'LL' modifier.
>>
> Yep that patch works too, same 9 more tests pass.
Please test with the latest git commit.
I corrected the previous patches, because:
o MinGW does not define __CYGWIN__, and __CYGWIN__ 64 bit became broken.
o check/lightning.c needs to call strtoull instead of strtoul to read
constants.
o There were incorrect register mappings left in previous patches.
I believe I tested in an environment as close as possible to the one you
are testing, and all tests pass.
I suppose the msys2 using mingw32 is passing all tests, but did not
verify it (did not install all packages, etc).
Thanks,
Paulo
- [Lightning] [PATCH] Fix 9 tests on Windows x64, due to size of long, Zachary Cook, 2019/10/03
- Re: [Lightning] [PATCH] Fix 9 tests on Windows x64, due to size of long, Zachary Cook, 2019/10/03
- [Lightning] [PATCH v2] Fix 9 tests on Windows x64, due to size of long, Zachary Cook, 2019/10/03
- Re: [Lightning] [PATCH v2] Fix 9 tests on Windows x64, due to size of long, Zachary Cook, 2019/10/03
- Re: [Lightning] [PATCH v2] Fix 9 tests on Windows x64, due to size of long, Paulo César Pereira de Andrade, 2019/10/03
- Re: [Lightning] [PATCH v2] Fix 9 tests on Windows x64, due to size of long, Zachary Cook, 2019/10/03
- Re: [Lightning] [PATCH v2] Fix 9 tests on Windows x64, due to size of long,
Paulo César Pereira de Andrade <=
- Re: [Lightning] [PATCH v2] Fix 9 tests on Windows x64, due to size of long, Zachary Cook, 2019/10/04
- Re: [Lightning] [PATCH v2] Fix 9 tests on Windows x64, due to size of long, Paul Cercueil, 2019/10/04
- Re: [Lightning] [PATCH v2] Fix 9 tests on Windows x64, due to size of long, Paulo César Pereira de Andrade, 2019/10/07
Re: [Lightning] [PATCH] Fix 9 tests on Windows x64, due to size of long, Paul Cercueil, 2019/10/03