Re: lightning 2.2.3 test failure on macos

[Rui]

Sounds good, gonna add the patch as well. Rui

On Tue, Sep 3, 2024 at 10:25 AM Paulo César Pereira de Andrade
<paulo.cesar.pereira.de.andrade@gmail.com> wrote:
>
> Em seg., 2 de set. de 2024 às 18:00, Rui <rui@chenrui.dev> escreveu:
> >
> > I think I just missed ", "--enable-assertions"" for my 2.2.3 build,
> > looks all good now. Thanks for the quick turnaround. Rui
>
>   Hi Rui,
>
>   --enable-assertions just adds several assert calls to the code. To detect
> possible encoding errors or any other issue "that should never happen".
>
>   The problem was some code checking NDEBUG and changing
> behavior. This patch fixes the issue:
>
> http://git.savannah.gnu.org/cgit/lightning.git/commit/?id=bfd695a94668861a9447b29d2666f8b9c5dcd5bf
>
> Thanks!
> Paulo
>