[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lilypond-auto] Issue 2613 in lilypond: Patch: add general_alignment
Re: [Lilypond-auto] Issue 2613 in lilypond: Patch: add general_alignment method (Rietveld 6308093)
Fri, 22 Jun 2012 13:54:51 +0000
Labels: -Patch-needs_work Patch-waiting
Comment #15 on issue 2613 by address@hidden: Patch: add
general_alignment method (Rietveld 6308093)
i'm very sorry that this happened. It's my fault; i had ran make to check
c++ code, but hadn't checked again after adding changes in docstrings. I
better since it's not the first time that docstrings bit me.
I apologise for wasting your time.
I also want to thank you for taking the time to show me the mistakes i
did. It's very kind of you, especially considering that you're correcting
my own sloppiness - the very one that caused the waste of your time.
Finally, to quote a developer that i hold in high esteem, let me express my
appreciation that you don't offload the onus of testing to the person
running Patchy, making sure that all your patches pass the test yourself.
I shall follow your lead in this respect.
There's a new version of the patch at http://codereview.appspot.com/6308093/
It passes make; i'll check regtests later so now i'm just setting its
status to patch-waiting.