[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes
From: |
lilypond |
Subject: |
Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes |
Date: |
Thu, 19 Jul 2012 17:37:17 +0000 |
Updates:
Labels: -Patch-needs_work Patch-review
Comment #35 on issue 2533 by address@hidden: Patch: line_count fixes
http://code.google.com/p/lilypond/issues/detail?id=2533
The changes to slurs are due to an intentional change that Pál pointed out
explicitly in his original review. There is a place slur-scoring.cc seems
to have used line-count slightly wrongly to determine if a slur need fit
among staff lines.
It makes sense to review the entire patch together as presented.
If the patch is good, it makes sense to commit logically-related sections,
such that each commit results in a working and consistent state of the code
-- *not* individual .cc files. If the changes to repeat-bars from the
original patch had been a separate commit, I would have been able to revert
only the troublesome part.
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/14
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/18
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/19
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/19
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/19
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/19
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/19
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes,
lilypond <=
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/19
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/20
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/20
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/20
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/20
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/20
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/20
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/20
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/21
- Message not available
- Re: [Lilypond-auto] Issue 2533 in lilypond: Patch: line_count fixes, lilypond, 2012/07/23