[Lilypond-auto] Issue 3007 in lilypond: Implement customizable fret-diagram mark properties

[lilypond]

Status: Accepted
Owner: ----
Labels: Type-Enhancement

New issue 3007 by address@hidden: Implement customizable fret-diagram  
mark properties
http://code.google.com/p/lilypond/issues/detail?id=3007

Eluze forwarded a post on the French users mailing to bug lilypond:

http://lists.gnu.org/archive/html/bug-lilypond/2012-12/msg00002.html

Eluze's post follows:


forwarding from the French LilyPond Forum:

http://lilypond-french-users.1298960.n2.nabble.com/Pattern-de-gammes-pour-la-guitare-fret-diagram-interface-td7578810.html


> Would it be possible to select a color for each point fret ?

> For example, if i use fret-diagram to display a scale and i want the root
> to be in red and the fifth in yellow and the other notes in black.


> Would it be possible to display the name of the note in the circle on the
> fret in place of the finger number ?

> For example, if i am displaying the root : R, the third minor: 3b, the
> fifth augmented: 5#, the seventh: 7 ...

I think that's an interesting feature (e.g. for teaching purposes, draw the
attention to a special tone …)

Eluze

The original poster clarified their feature request. A translation to  
English can be found here:

http://lists.gnu.org/archive/html/bug-lilypond/2012-12/msg00005.html

Quote:
------
December 4, 2012, 5:29 pm   ??l??andar

I think there are three themes (at least):

- Add any color possible
- process color (and other properties?) individually
(expand cargo space-dimension color)
- allow other signs that the numbers roman / arabic you have any other  
ideas?


It would be nice if in addition to color, you could place a sign, specify a
text (circled) eg: "5J" for straight or just "3b" or "3m" for minor  
third "3"
or "3M" for major third ... As a language to another designations may  
vary ...
Instead of text, it could also simply specify the name of the interval and  
if
necessary lilypond result in the target language? level of implementation, I
think it would give the possibility to the user to specify the format of the
list of points (description of each). The various possibilities which I  
think
(string, freight, finger, color, text, or interval). So if the user  
specifies
the following format:   + (string, cargo, color) will seize eg 4-4-red   +
(string, cargo, color, interval) will seize eg 4-5 {-yellow- 3M}   +  
(string,
freight, finger) will seize eg 4-5-1  ...
---------
Unquote

One of the devs, MS, started the discussion on how this could be implemented

http://lists.gnu.org/archive/html/lilypond-devel/2012-12/msg00078.html

quoting:


> Hi,

> I'm handling a feature request on bug-lilypond for some enhancements
> to the fret diagram features.

> http://lists.gnu.org/archive/html/bug-lilypond/2012-12/msg00002.html

> I don't think the new functionality has been adequately defined by
> those who requested it.

> Could one or more of the devs advise me on whether to accept the
> request, reject it, or press for further definition?

> If you think a request for further definition is the correct response,
> please be specific about what is missing.


> Cheers,
> Colin.

The easiest thing to do would be to create a context property that is a  
list of
alists, where each alist corresponds to a string from low to high.  So, for
example, for a two-string instrument, something like :

\set fretMarkProperties = #'(((color . red) (type . letters) (upsidedown .  
#f))
((color . blue) (type . numbers)))

This can include whatever parameters make sense and can be fed to the fret
diagram constructor.  After this is implemented, wrapper functions can do  
what
this person is talking about (i.e. a Scheme function that identifies
roots/thirds/fifths and then composes the list of alists accordingly).

So as a request, I'd put "Implement customizable fret-diagram mark  
properties"
or something of the like.  How the customizations are used is up to the  
user.

Cheers,
MS