lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lilypond-auto] Issue 3261 in lilypond: regtest 'incipit.ly' compres


From: lilypond
Subject: Re: [Lilypond-auto] Issue 3261 in lilypond: regtest 'incipit.ly' compressed
Date: Fri, 29 Mar 2013 19:50:53 +0000

Updates:
        Status: Fixed
        Cc: address@hidden
        Labels: Fixed_2_17_15

Comment #10 on issue 3261 by address@hidden: regtest 'incipit.ly' compressed
http://code.google.com/p/lilypond/issues/detail?id=3261

And you are right: the result is totally broken now. However, that is not caused by my work on incipits, but rather by

commit 6e4e69f2735a764eab2e6f70f83546461da0203b
Author: Mike Solomon <address@hidden>
Date:   Fri Mar 29 05:55:13 2013 +0100

    Uses special X alignment for instrument names.

    Previously, instrument names used the side-position-interface for
    calculations in its alignment function.  This made no sense, as it never
    had any side-support elements, requiring a kludge to get them to
    align properly.

    Here, we remove that kludge and align them by aligning them to their
    right end and adding padding.  We also change the name of the grob array
    in which vertical axis groups are stored to
    system-start-text-align-elements so that the grob is not accidentally
    treated as an axis-group implementing an elements array.

Of course, the commit id can't be found in any issue, and there is no issue number mentioned. It also does not seem like the commit title is part of an issue.

So I have no clue what issue this change have purportedly be tested with. I am closing this issue as fixed. You may reopen a different issue for the breakage caused by the above commit if you want to, but this issue here definitely has been dealt with right before the above commit broke it in a completely different way that would likely also have hit the old code.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings



reply via email to

[Prev in Thread] Current Thread [Next in Thread]