lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lilypond-auto] Issue 3664 in lilypond: Patch: Support articulations


From: lilypond
Subject: Re: [Lilypond-auto] Issue 3664 in lilypond: Patch: Support articulations, slurs and breaths in MIDI.
Date: Wed, 27 Nov 2013 08:55:44 +0000

Updates:
        Labels: -Patch-needs_work Patch-review

Comment #21 on issue 3664 by address@hidden: Patch: Support articulations, slurs and breaths in MIDI.
http://code.google.com/p/lilypond/issues/detail?id=3664

Regarding comment #20: appears like clerical error to me. You have to keep in mind that the Patch meister (who is not! a core programmer) just looks at the discussions in the Rietveld issues and has to decide whether there is unilateral agreement in the comments.

Now this discussion has a <em>lot</em> of back and forth material. It happens that <em>all</em> of this back and forth is focused on feature wishlists that are not even <em>related</em> to this issue. But that's not immediately obvious without digging in, and the Patch meister does a clerical job. It's not in his job description to dig in since that would require different qualifications and make for an entirely different workload (and the workload is more than enough).

That's one reason it is a bad idea to carry on unrelated discussions in the review tracker (remove the respective mail address when replying if it is not relevant to the review).

I'm putting the patch back to Patch-review for that reason and it should have a good chance to get through next iteration. It's not like it is in much danger to miss the time frame for 2.19.0 anyway.

In general, when you have good reason to see a factual error with your patch state, it's ok to reset it to Patch-review (on an unchanged patch that has been subjected to the official testing before). Otherwise, the label "Patch-needs_work" will stick. The Patch meister himself does not touch "needs_work", and nobody else usually will, either.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings



reply via email to

[Prev in Thread] Current Thread [Next in Thread]