Re: [Lilypond-auto] Issue 4096 in lilypond: \addlyrics always creates its own Voice context

[lilypond]

Updates:
        Labels: Patch-new

Comment #1 on issue 4096 by address@hidden: \addlyrics always creates its own  
Voice context
https://code.google.com/p/lilypond/issues/detail?id=4096#c1

Issue 4096: \addlyrics always creates its own Voice context

Contains commits:


Give \addlyrics the power of christening the associated context

With

\new Voice \with { \stemDown } { c1 } \addlyrics { Oh }

as opposed to

\new Voice = "upper" \with { \stemDown } { c1 } \addlyrics { Oh }

\addlyrics created its own context (consequently not using \stemDown)
since it had no context name for the Lyrics context to attach to.  In
this case (namely being preceded by an unnamed new Voice context), it
will now give a name to the context itself.


Fix bugs preventing \addlyrics from finding an existing context to attach to


Refactor grammar to give \addlyrics a good target to attach to

So far,

    \new Staff \new Voice { c1 } \addlyrics { Oh } \addlyrics { Ah }

was factored as

    \new Staff \new Voice { { c1 } \addlyrics { Oh } \addlyrics { Ah } }

which resulted in something like

   \new Staff \new Voice
     << \context Voice = "uniqueContext0" { c1 }
        \new Lyrics \lyricsto "uniqueContext0" { Oh }
        \new Lyrics \lyricsto "uniqueContext0" { Ah }
     >>

This made it impossible to work with the likes of

  \new Staff \new Voice \with { \stemUp } { c1 } \addlyrics ...

since the voice the lyrics attached to was always a new voice.
Fixing the grouping in the grammar is a first required step for getting
this under control.


Refactor grammar, folding re_rhythmed_music into composite_music


Refactor grammar, folding complex_music into composite_music

http://codereview.appspot.com/142720043

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings