[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4011 Completion_heads_engraver should not repeat forced/cautionary accidentals

[Auto mailings of changes to Lily Issues]

---

[issues:#4011] Completion_heads_engraver should not repeat forced/cautionary accidentals

Status: Accepted
Labels: Frog
Created: Sun Jul 13, 2014 02:02 PM UTC by Anonymous
Last Updated: Sat May 02, 2015 04:30 PM UTC
Owner: nobody

Originally created by: *anonymous

Originally created by: address@hidden

---

From Issue 3593:

Cf thread starting with <URL:http://lists.gnu.org/archive/html/lilypond-user/2013-10/msg00036.html>.

This shows several issues with the completion heads engraver's treatment of accidentals.  This issue is about the regression, namely accidentals occuring in tied-after notes.

The regression started with
2.17.2.

[r6c98920d868524eee3e809578ad4389d409a566a] is the first bad commit
commit [r6c98920d868524eee3e809578ad4389d409a566a]
Author: Mike Solomon <address@hidden>
Date:   Mon Sep 10 08:53:09 2012 +0200

    Avoids script-tie collisions
   
    Ties are now issued at their correct beginning time step and
    are suicided if they are ultimately unused.  This allows the
    Script_engraver to acknowledge them at the correct timestep and
    register them as supports for the side-position-interface.

The changes in that commit were not reflected in the completion engravers.  The fix chosen here is _not_ a full reflection of the changed design: while the ties' ends are now being announced (this omission caused the original problem), the beginnings of the ties are announced at the same point of time.  That means that overrides and similar are taken from the time at the _end_ of the tie, and it is conceivable that the collision avoidance mechanisms are not fully operative (though reasonably they can't be expected to start work before the end of the tie is known).

A more comprehensive rewrite would be warranted.

What this issue is _not_ about are the non-regression issues mentioned in the thread: repetition of _forced_ accidentals and of articulations.

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://makebettercode.com/inteldaal-eval

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto