|From:||Auto mailings of changes to Lily Issues|
|Subject:||[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4877 Revert #4747: (Remove (all) uses of is-absolute?|
|Date:||Fri, 03 Jun 2016 08:36:18 +0000|
Iff the revert went fine without any merge conflicts, the original state should have seen years in testing already. I don't see a point in additional manual testing then, in particular since it is highly unlikely to expose any syptoms of this change. I recommend to just push to staging and let the automated Patchy-staging fend off the worst offenses.
If you had to resolve merge conflicts manually, however, review would make more sense.
[issues:#4877] Revert #4747: (Remove (all) uses of is-absolute?
Created: Fri Jun 03, 2016 07:53 AM UTC by Urs Liska
Last Updated: Fri Jun 03, 2016 07:53 AM UTC
Owner: Urs Liska
Revert #4747: (Remove (all) uses of is-absolute?
Author: Urs Liska address@hidden
Date: Tue Jan 19 10:52:33 2016 +0100
#4747: Remove (all) uses of is-absolute?
As discussion revealed the commit message is not true
and indicates a misconception (see quote below).
(car ly:input-file-line-char-column a-location) does
not always return an absolute path, instead this
depends on how the file path has been passed to LilyPond.
As this commit changed the behaviour of point-and-click
in a somewhat unintentional and unmaintainable way it
is better to revert the commit. Especially as the
original behaviour was not harmful in the first place.
(Original commit message:)
The check for absolute paths in in output-ps.scm
and -svg.scm is unnecessary because
(car ly:input-file-line-char-column a-location)
always returns an absolute, slashified path
Now is-absolute? is not used anymore by LilyPond itself.
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
|[Prev in Thread]||Current Thread||[Next in Thread]|