[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4899 Reorgani

From: Auto mailings of changes to Lily Issues
Subject: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4899 Reorganize listener/acknowledger initialization
Date: Thu, 23 Jun 2016 07:31:39 +0000

I am going to push this a day early, in a few hours. Reason is that issue 4903 (which has a hard time getting tested at all) actually overlaps with this one and consequently needs non-trivial rebasing. And I have patches waiting to be rebased on that as well, and I try working on issue 1375 based on the code state of that, and stuff is getting out of hand enough that it causes me to deadlock and get nothing done.

So I'll be flushing some queues and we'll need to deal with any fallout afterwards rather than through proper review. Sorry for that. I still have a few issues on regular schedule not interfering with ongoing work.

[issues:#4899] Reorganize listener/acknowledger initialization

Status: Started
Created: Sat Jun 18, 2016 11:55 AM UTC by David Kastrup
Last Updated: Tue Jun 21, 2016 07:38 AM UTC
Owner: David Kastrup

Reorganize listener/acknowledger initialization

This reverts most of the changes of issue 4885 in order to arrive at
listeners/acknowledgers that can be kept private or protected
according to the actual use cases in engravers and other translators.
It also streamlines some of the other code. Contains the following
commits in reverse order (all separately tested to compile):

Remove {Translator,Engraver}::ack_find_base

The indirection and complication added by it does not really
help in any manner.

Remove Translator::method-find_base

It's basically a trivial replacement and confuses more than it helps.

Listeners should not be virtual

Gregorian_ligature_engraver::listen_pes_or_flexa and
Ligature_engraver::listen_pes_or_flexa were accidentally
declared virtual, but their registration already caters
for what amounts to virtual overrides in effect.

Revert "Issue 4885/2: Let ADD_ACKNOWLEDGER state actual classes"

This reverts commit 7c36dbb1834c7c68e4b94777241de3ea02971aca.

Revert "Issue 4885/3: Remove ack_finder/ack_find_base"

This reverts commit b9040afd1dcfbee6b45bc3d54850ff50d51c8ee9.

Let method_finder also find listeners

This allows using inherited listeners directly like with
acknowledgers and translator methods.

Sent from because address@hidden is subscribed to

To unsubscribe from further messages, a project admin can change settings at Or, if this is a mailing list, you can unsubscribe from the mailing list.

Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
Testlilyissues-auto mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]