[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5119 MIDI2Ly

From: Auto mailings of changes to Lily Issues
Subject: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5119 MIDI2Ly fraction reduction
Date: Sat, 27 May 2017 09:00:23 +0000

This fails a basic 'make' when applied to current master.

Also Christopher, if and when you submit a new patch, can you clean up the whitespace errors that are also reported ('git apply' squelches some, but I can see that you are using tabs in the diff on Rietveld and this will cause comments by other devs). Also see:

[issues:#5119] MIDI2Ly fraction reduction

Status: Started
Created: Sun Apr 16, 2017 02:32 PM UTC by Colin Campbell
Last Updated: Sat May 27, 2017 08:22 AM UTC
Owner: pkx166h

Submitted by Christopher Heckman:

When midi2ly is run, it will print fractions with large numerators
and denominators, like

r4361/120 e429/120 r431/120 e459/120 r4361/120 e429/120

when the actual durations are more likely to be

r2. e41/4 r41/4 e41/2 r2. e41/4 r41/4 e41/2 r2. e4*1/4

I have written a patch to fix this.

Fixes to better note lengths, now supports meter changes

(1) Note lengths currently are fractions like 61/120. If the numerator
can be changed by 1 to get a better fraction, it is done. Quarter
notes are also replaced with eighths/sixteenths if appropriate.
For example: a duration of 461/120 is changed to 41/2 and then
to 8. (2) Current version of midi2ly does not support meter changes.
Patch does.

Resolves: #5119

Sent from because address@hidden is subscribed to

To unsubscribe from further messages, a project admin can change settings at Or, if this is a mailing list, you can unsubscribe from the mailing list.

Check out the vibrant tech community on one of the world's most
engaging tech sites,!
Testlilyissues-auto mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]