[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4807 Wrong glissando slopes with accidental in target chord

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

After looking at that commit (b47350d1) and at issue [#40] it looks to me as if one could simply revert this commit and get correct behaviour for both cases (issue 40 and this issue), make check shows no other problems. But of course there was a reason fo that commit so I’m confused …

--- a/lily/line-spanner.cc
+++ b/lily/line-spanner.cc
@@ -114,7 +114,7 @@ Line_spanner::calc_bound_info (SCM smob, Direction dir)
                       ? Axis_group_interface::generic_bound_extent (bound_grob, commonx, X_AXIS)
                       : robust_relative_extent (bound_grob, commonx, X_AXIS)).linear_combination (attach);

-      Grob *acc = unsmob_grob (bound_grob->get_object ("accidental-grob"));
+      Grob *acc = Note_column::accidentals (bound_grob->get_parent (X_AXIS));
       if (acc && to_boolean (ly_assoc_get (ly_symbol2scm ("end-on-accidental"), details, SCM_BOOL_F)))
         x_coord = robust_relative_extent (acc, commonx, X_AXIS).linear_combination (attach);

Attachments:

• glissando_accidental_collision.png (60.3 kB; image/png)

---

[issues:#4807] Wrong glissando slopes with accidental in target chord

Status: Accepted
Labels: regression
Created: Mon Mar 21, 2016 10:59 AM UTC by Simon Albrecht
Last Updated: Mon Mar 21, 2016 12:17 PM UTC
Owner: nobody
Attachments:

• 4807-2.16-no-bug.png (4.9 kB; image/png)
• 4807-2.18-bug.png (5.4 kB; image/png)

As Harm reported, glissando slopes may be wrongly calculated, if there is an accidental on the target chord. This worked fine in v2.16.2.

\version "2.18.2"
%% up to 2.19.39

{ <d f>1\glissando <fis'' a''>1 }

%% this one is ok:
{ <d f>1\glissando <f'' a''>1 }

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto