|From:||Auto mailings of changes to Lily Issues via Testlilyissues-auto|
|Subject:||[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4603 change all occurences of ‘partcombine’ to ‘partCombine’.|
|Date:||Sat, 15 Dec 2018 01:51:54 -0000|
Change \partcombine (et al.) to \partCombine
I figured I’d try and rebase/update/complete Charles’ previous
proposal in case someone ever decides to apply it.
In which case, I guess \autochange should be updated as well;
that’s the only other multi-word command I could find that
had’nt been previously camelCased as part of Graham’s
`Grand Syntax Stabilization’ project a few years back.
… Well, unless you count \defaultchild and \grobdescriptions,
but that’s not something the average user tends to be exposed to.
Then again, for some reason we do still have \fontsize and
\normalsize, all lower-case (camelCase being precisely what
sets apart fontSize, as a property, from \fontsize as a command).
I personally don’t have more than a slight preference towards
\partCombine and \autoChange, and I wouldn’t dare to guess
how much damage this syntax break could cause (though my
we’ve definitely seen worse in the past, this one being
fairly trivially handled by convert-ly).
And, yes, I’m well aware that there still are much bigger
fishes to fry at the moment (but that’s already what
got the \partcombine patch stuck in limbo last year).
[issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.
Created: Sun Sep 13, 2015 03:17 PM UTC by pkx166h
Last Updated: Sat Dec 15, 2018 01:51 AM UTC
On 13/08/15 21:42, Malte Meyn wrote:
the case of the ‘c’ in partcombine is inconsistent, confusing me every
time I use \partcombine(Apart|Chords|…):
\partcombine, \partcombineApart, … but
I would suggest to change all occurences of ‘partcombine’ to ‘partCombine’.
Why not change ‘partCombine’ to ‘partcombine’? Because I looked at the
engravers which use the more ‘natural’ underscore instead of camelCase
for spaces. And in the same way as ‘Cue_clef_engraver’ suggests that
‘cue clef’ are two words (resulting in ‘cueClefGlyph’, not
‘cueclefGlyph’), ‘Part_combine_engraver’ does.
I think that this would be rather easy to change.
Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and convert-ly rule added to go along with.
http://codereview.appspot.com/323040043 - part 1 of 3
http://codereview.appspot.com/326870043 - part 2 of 3
http://codereview.appspot.com/327970043 - part 3 of 3
Note this will require both a convert.ly and a makelsr.py run to make sure that the patch passes all the tests.
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
|[Prev in Thread]||Current Thread||[Next in Thread]|