[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5475 Dedicate

From:

Auto mailings of changes to Lily Issues via Testlilyissues-auto

Subject:

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5475 Dedicated functions for negative predicate tests

Date:

Fri, 08 Feb 2019 12:31:02 -0000

Description has changed:

Diff:

Needs: -->
Patch: new --> review
Type: --> Enhancement
Comment:

Passes make., make check and a full make doc.

large reg test diffs

Download zip file from here

https://nc-cluster02.yourownnet.cloud/index.php/s/b5c7k9pgzKmZBGB

(33mb zipped)

[issues:#5475] Dedicated functions for negative predicate tests

Status: Started
Created: Fri Feb 08, 2019 08:02 AM UTC by Valentin Villenave
Last Updated: Fri Feb 08, 2019 09:15 AM UTC
Owner: Valentin Villenave

Dedicated functions for negative predicate tests

Negative tests, e.g. (not (null? x)), are everywhere
in Scheme functions. Having dedicated functions for
the most common ones may allow to make the code a bit
lighter (and possibly very slightly faster).

This patch includes tests for not-null?, not-zero?,
not-integer?, not-number?, not-symbol?, not-string?
and not-list?, as well as a C++-defined not-pair?
that may be used instead of the already-existing one
found in srfi-1. (These are all available as ly:-prefixed
functions as well, which may help in case something
changes in upstream Guile.)

It is, however, a rather substantial addition (turning
some Scheme functions into somewhat of a non-standard
dialect, even though the syntax remains self-evident), and is
therefore open to discussion -- or outright rejection :-)

http://codereview.appspot.com/345190043

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.