[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5309 find_sco

From: Auto mailings of changes to Lily Issues via Testlilyissues-auto
Subject: [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5309 find_score_context () and find_global_context ()
Date: Thu, 16 Jan 2020 19:43:49 -0000

Patch counted down - please push.

[issues:#5309] find_score_context () and find_global_context ()

Status: Started
Created: Sat Apr 21, 2018 06:37 PM UTC by Dan Eble
Last Updated: Sun Jan 12, 2020 09:09 AM UTC
Owner: Dan Eble

1: find_score_context ()

Translator::find_score_context () finds the Score context enclosing
the Translator in a way similar to (but slightly more direct than)
\set Score.whatever = ... rather than depending on the global context.

Global_context::get_score_context () returns the first child, as
before, but it is no longer a virtual method of Context, and it is used
in fewer places.

2: find_global_context ()

Replace c->get_global_context () with find_global_context (c). This
function does not need to access any private information of Context, so
pulling it out simplifies the interface of Context. Calling it "find"
rather than "get" is supposed to imply more work (walking the tree).

Implement find_global_context (c) as find_top_context (c) plus a type
check. This increases code reuse and requires fewer dynamic casts.
Abort the program if the top context is not a Global context, otherwise
most callers would dereference null pointers.

Sent from because address@hidden is subscribed to

To unsubscribe from further messages, a project admin can change settings at Or, if this is a mailing list, you can unsubscribe from the mailing list.

Testlilyissues-auto mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]