Re: make web (documents) on OSX

[Matthias Kilian]

On Wed, May 11, 2005 at 01:57:55AM -0700, Graham Percival wrote:
> OSX ulimit -n is set to to 256 by default.  A while ago, I increased 
> that
> to 512 to allow lilypond to build.  I'm not certain if this is still 
> necessary,
> and I'd completely forgotten about that line in my ~/.profile
> I tried setting it to 2048 and the docs built successfully.

If it's makeinfo that's bailing out, tuning the limits is the wrong
solution to the right problem :-)

There's a file descriptor leak in the official texinfo-4.8. Below's
a patch for it (and some other bugs). Note that there are more small
indexing bugs; I allready sent all my patches to Karl Berry.

Ciao,
        Kili

--- makeinfo/html.c.orig        Mon Dec  6 02:13:06 2004
+++ makeinfo/html.c     Tue Apr  5 17:17:15 2005
@@ -167,6 +167,8 @@ process_css_file (char *filename)
       lastchar = c;
     }
 
+  fclose(f);
+
   /* Reached the end of the file.  We should not be still in a comment.  */
   if (state == comment_state)
     warning (_("%s:%d: --css-file ended in comment"), filename, lineno);
@@ -437,7 +439,9 @@ rollback_empty_tag (char *tag)
   int check_position = output_paragraph_offset;
   int taglen = strlen (tag);
   int rollback_happened = 0;
-  char *contents = "";
+  char *contents = "";                 /* FIXME (ptr to constant, later
+                                          assigned to malloc'd address).
+                                        */
   char *contents_canon_white = "";
 
   /* If output_paragraph is empty, we cannot rollback :-\  */
@@ -445,7 +449,7 @@ rollback_empty_tag (char *tag)
     return 0;
 
   /* Find the end of the previous tag.  */
-  while (output_paragraph[check_position-1] != '>' && check_position > 0)
+  while (check_position > 0 && output_paragraph[check_position-1] != '>')
     check_position--;
 
   /* Save stuff between tag's end to output_paragraph's end.  */
@@ -462,7 +466,7 @@ rollback_empty_tag (char *tag)
     }
 
   /* Find the start of the previous tag.  */
-  while (output_paragraph[check_position-1] != '<' && check_position > 0)
+  while (check_position > 0 && output_paragraph[check_position-1] != '<')
     check_position--;
 
   /* Check to see if this is the tag.  */