Re: Updating translators

[Han-Wen Nienhuys]

Erik Sandberg schreef:
> BTW, how long should incoming stream events be protected? Is it OK to flush 
> the protection buffer each moment, or should I wait until the context is 
> removed?

the latter is safer. We can optimize if necessary later.

> > rather use a derived_mark() and a vector<Event*>
>
> I think I'll use a native Scheme list.

Hmm. That also adds some memory overhead (allocing and deallocing cells.)

> > > -bool
> > > -Arpeggio_engraver::try_music (Music *m)
> > > +IMPLEMENT_TRANSLATOR_LISTENER (Arpeggio_engraver, hear_arpeggio,
> > > "ArpeggioEvent"); +void Arpeggio_engraver::hear_arpeggio (Stream_event
> > > *ev)
> > can you reengineer this to have less redundancy? I would expect that you
> > can get enough info from
> >
> >    IMPLEMENT_TRANSLATOR_LISTENER (Arpeggio_engraver, arpeggio)
>
> I don't understand. What is redundant? I can't reacall any other place where I 
> give the information that the arpeggio method wants to hear events of class 
> ArpeggioEvent.

the word arpeggio is in there thrice.

--

Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen

LilyPond Software Design
 -- Code for Music Notation
http://www.lilypond-design.com