|
From: | Han-Wen Nienhuys |
Subject: | Re: page breaking cleanups |
Date: | Sat, 19 Aug 2006 20:00:59 +0200 |
User-agent: | Thunderbird 1.5.0.5 (X11/20060803) |
Joe Neeman wrote:
+static bool +break_p (Grob *g) +{ + (void) g; /* shutup warning */ + return false; +}
can we loose the _p suffixes? use is_break() for the function and Break_predicate for the type.
-vector<Line_details> -Page_breaking::get_line_details (vsize start_break, vsize end_break, vector<vsize> const &div)
+vector<SCM> +Page_breaking::systems ()
this looks like a potential memory error. The SCM vector is allocated on the heap, and hence, is not GC scanned, and may be freed prematurely. Please double check
+void Page_breaking::find_chunks_and_breaks (Break_p break_p)
void Page_breaking:: .. (note line break) -- Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen LilyPond Software Design -- Code for Music Notation http://www.lilypond-design.com
[Prev in Thread] | Current Thread | [Next in Thread] |