[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Why not set TextScript.Y-offset in define-grobs.scm?

From: Han-Wen Nienhuys
Subject: Re: Why not set TextScript.Y-offset in define-grobs.scm?
Date: Fri, 20 Oct 2006 18:23:55 +0200
User-agent: Thunderbird (X11/20061008)

Joe Neeman schreef:
On Fri, 2006-10-20 at 12:08 +0200, Han-Wen Nienhuys wrote:
Joe Neeman schreef:
As far as I can tell, whenever a TextScript object is created, it is
immediately sent to Side_position_interface::set_axis(Y_AXIS). It seems
that it is better to just set Y-offset and side-axis in
define-grobs.scm. Is there a reason this is not done? Same thing applies
to Script.
the reason is that scripts coming from new-fingering-engraver don't follow this pattern. But in general it shouldn't hurt to have a default.
Just test in advance, to see whether it has unexpected side effect.

But new-fingering-engraver calls make_script_from_event, which calls
Side_position_interface::set_axis(Y_AXIS), so it should still be ok,

Anyway, here is the patch. doesn't complain about it.

good. please apply.


Han-Wen Nienhuys - address@hidden -

LilyPond Software Design
 -- Code for Music Notation

reply via email to

[Prev in Thread] Current Thread [Next in Thread]