[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: skyline vertical spacing

From: Han-Wen Nienhuys
Subject: Re: skyline vertical spacing
Date: Sun, 26 Nov 2006 19:33:47 +0100
User-agent: Thunderbird (X11/20061107)

Han-Wen Nienhuys escreveu:
> Joe Neeman escreveu:
>> I have fixed all known regressions in the jneeman branch. The addition
>> of max-slope skylines changes slightly the output of
>> input/regression/ <>, but IMHO it looks
>> better now (the ties aren't quite so close together).
>> I haven't yet made max-slope configurable or incorporated Erik's
>> suggestion for increasing horizontal distance in skylines.
>> Are there any objections for me to merge the patch to HEAD?
> No, please go ahead.

out of curiosity, I've pulled your patch and put it into master.

Some remarks:

 - can you use git-rebase for the next time? Now, we get lots of
   commits duplicated in the log.

 - I'm missing the input/regression test file showing the new goodies,
   as well as the NEWS entry

 - on a random sample (mozart horn concerto), the skyline stuff looks
   working. However, should we increase the default
   padding/skyline-padding to improve appearance (see mozart concerto,
   page 1, bar 68, forte and beam being close)?


Han-Wen Nienhuys - address@hidden -

LilyPond Software Design
 -- Code for Music Notation

reply via email to

[Prev in Thread] Current Thread [Next in Thread]