lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: musicxml merge


From: Han-Wen Nienhuys
Subject: Re: musicxml merge
Date: Thu, 13 Sep 2007 16:27:00 +0200

2007/9/13, Reinhold Kainhofer <address@hidden>:
> > +        if filename[-1] == '.':
> > +            filename += "xml"
> > +        elif not re.match ("\.xml$", filename):
> > +            filename += ".xml"
> >
> > this looks a bit strange.
> > Do you mean a boolean or here?
>
> No, I'm checking the filename and appending .xml if it's not there (or only
> xml if the filename already ends in a "."). The logic is:
>
> If file with given filename exists => Use that filename

both if-bodies are the same. That can't be right.

> > +# empty
> > +
> > +# UGH UGH
> > +include $(make-dir)/lilypond-vars.make
> > +
> >
> > why is this needed?
>
> mainly because the binaries are defined there...

but you're already including lilypond stuff from the GNUmakefile.

> > also, if you feel adventurous, you could look into getting the
> > musicxml files into the regtest; I'll have a look at it when possible,
> > but it will probably be end of september earliest.
>
> The main problem I ran into was how to create pdfs from the .ly files. I had
> hoped that simply giving the .pdf files as targets would build the .ly files
> from the .xml and then the .pdf from .ly, but apparently I'm missing
> something in the makefiles for this to work.

the real solution is to create a texidoc document, similar to how
input/regression/ does it; try running

  make test

to see what happens there.

-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen




reply via email to

[Prev in Thread] Current Thread [Next in Thread]