Re: [PATCH] Fix #655, \remove should emit warning for unknown engravers (in \with)

[Han-Wen Nienhuys]

On Fri, Aug 15, 2008 at 1:48 PM, Neil Puttock
> There are two related issues which I'm concerned about:
>
> - Should an unknown engraver cause compilation to fail? I was
> wondering whether it might be better to issue a warning rather than an
> error in get_translator ().

No, in general, we should try to never let compilations fail;  that
is: there should be an error message, but the program may not abort.

> - There's a redundant error message in Context_def::add_context_mod
> (); it never gets called, since compilation stops in get_translator
> ():
>
> if (!get_translator (sym))
>  error (_f ("program has no such type: `%s'", ly_symbol2string
> (sym).c_str ()));

that's just fine - an extra safety net does not hurt.

-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen