[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Code review tool? (and [PATCH] fix for stencil rotating)

From: Reinhold Kainhofer
Subject: Re: Code review tool? (and [PATCH] fix for stencil rotating)
Date: Wed, 10 Sep 2008 11:48:35 +0200
User-agent: KMail/1.9.10

Hash: SHA1

Am Dienstag, 9. September 2008 schrieb Han-Wen Nienhuys:
> What do you think of using codereview.appspot for code reviews?

While I like the idea of using something like that, I find google's service 
too limited and too svn-centric. In particular, it works on a file-basis 
rather than on patch sets.
It also automatically includes all changes and does not let you select which 
changes you want to submit. If you work on a basic issue and something else 
that is based on it, you can't upload e.g. a patch that you committed locally 
separately already from some uncommited changes. Also, if you committed 
something locally, git-cl will completely ignore this and ask you again for a 
summary (and doesn't ask for a description). 
Another issue is that it relies on your Address (I suppose using it 
as the sender's address for the CCs), so mails to lilypond-devel will not 
automatically go throught, because these addresses are not subscribed (unless 
your are already using gmail like hanwen).

If that tool were tailored to git, it would take one local commit (identified 
by the hash) and upload it as a git patch, taking the summary/description 
from the patch. Patches, which are dependent on each other would then also be 
no problem.

Anyway, I also did a test run for my fix to stencil rotation:

Please ignore the file, which just contains some debug code 
to check whether the bounding boxes are now rotated correctly. I never meant 
to submit it (and I also didn't add it to my local git commit, but git-cl 
does not look at git commits and does not let you select files/changes 
individually, but can only upload all local changes).
Both patch sets are identical up to a small change in, 
which should be ignored anyway.

- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden,
 * Financial and Actuarial Mathematics, TU Wien,
 * K Desktop Environment,, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien",
Version: GnuPG v1.4.6 (GNU/Linux)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]