lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add a ly:line-thickness callback for scheme, returning the line thi


From: Reinhold Kainhofer
Subject: Re: Add a ly:line-thickness callback for scheme, returning the line thickness
Date: Fri, 12 Sep 2008 11:37:17 +0200
User-agent: KMail/1.9.10

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Freitag, 12. September 2008 schrieb address@hidden:
> http://codereview.appspot.com/5073/diff/1/3#oldcode42
> Line 42: 1, 0, 0, (SCM grob),
> It looks as if you have the patch reversed.
>
> Perhaps git-cl confusion?

Oops, you are right! Since git-cl requires you to manually specify which code 
points you want to diff, I confused HEAD^ with HEAD^^ and got the direction 
wrong (thinking "I want to diff the previous state HEAD^ with the state 
before, i.e. HEAD^^", while git-diff takes the arguments in the opposite 
order). Hopefully the changes in git-cl will make such issues a thing of the 
past.

Corrected patch uploaded as second patch set:
http://codereview.appspot.com/5073

Cheers,
Reinhold

- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIyjhTTqjEwhXvPN0RAturAJ4u51pPS6g1aeiabMqS9eK2J3FCtQCgk8kQ
a+L1UqahofgzW8FDkvMG+Y4=
=lJeM
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]