lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Review of text.itely


From: Valentin Villenave
Subject: Re: Review of text.itely
Date: Sun, 23 Nov 2008 16:26:51 +0100

2008/11/23 Trevor Daniels <address@hidden>:

> I've just reviewed text.itely.  I think this is mainly your work and very
> impressive it is!  I made only three minor changes, of which only one is
> significant.  If you can find a couple of minutes perhaps you could check
> these out to be sure I've not screwed anything up.

I'm happy with your changes. I've had a hard time trying to explain
the purpose of the pango-tree overriding, so I guess yours is better.

> There are one FIXME and two TODOs left, which I'd like to see handled before
> we move text.itely to 'finished' status.  Could you see if these are still
> relevant?  If so, would you like me to deal with them?

Oh, that would certainly be of great help (my opera's deadline was
three weeks ago, and I still have one scene to write).

The FIXME, at least, has to be dealt with; the TODO snippets are
probably not mandatory but it would be nice to have them.

Many thanks for the offer, I'll owe you one!

Cheers,
Valentin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]