[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bugfix patch reviewing
From: |
Carl D. Sorensen |
Subject: |
Re: bugfix patch reviewing |
Date: |
Sun, 4 Jan 2009 19:16:23 -0700 |
On 1/4/09 3:46 PM, "Han-Wen Nienhuys" <address@hidden> wrote:
> Changes which look innocuous can cause problems in other areas. I'd
> like to request that the frogmeister be responsible for running each
> change through the regression test, ie.
>
> git checkout pristine
> make test-baseline
> git-apply-patch bugfix
> make check
>
> For the rest, the patches should be reviewed, and in the case of
> bugfixes, accompanied by a regtest file; I trust Carl's judgement to
> not apply what he is not comfortable with.
>
OK, I can do this.
I assume "pristine" is a branch that tracks origin/master. Is that correct?
Carl