[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Move left-broken line-spanner check to callback.
|
From: |
joeneeman |
|
Subject: |
Move left-broken line-spanner check to callback. |
|
Date: |
Wed, 08 Apr 2009 20:42:51 +0000 |
One minor comment, otherwise lgtm
http://codereview.appspot.com/32148/diff/1/7
File lily/spanner.cc (right):
http://codereview.appspot.com/32148/diff/1/7#newcode426
Line 426: Spanner::after_line_breaking (SCM grob)
Can you think of a name that describes what the function actually does?
Like Spanner::suicide_if_spanned_time_is_empty, but maybe less
verbose...
http://codereview.appspot.com/32148
- Move left-broken line-spanner check to callback.,
joeneeman <=