lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [frogs] patch for issue 708


From: Neil Puttock
Subject: Re: [frogs] patch for issue 708
Date: Sun, 24 May 2009 11:49:08 +0100

2009/5/24 Carl D. Sorensen <address@hidden>:
> Thanks,  Applied.

Unfortunately, there are two serious flaws here:

- keySignature alists which aren't backquoted (e.g., the example in
the bug tracker) will be ignored

- entries of the form (notename . alteration) are mangled:

\set Staff.keySignature = #'((0 . 2) (1 . 2)  (4 . 2))

-> \set Staff.keySignature = #`(((0 . 2) . ,SEMI-SHARP)
                             ((2 . 4) . ,SHARP))

Less seriously, the two conversion functions appear to be identical
apart from the different dictionaries for alterations.  Would it be
possible to use a single `fixKS' function with the dictionaries passed
as an argument to cut down on the duplication?

Regards,
Neil




reply via email to

[Prev in Thread] Current Thread [Next in Thread]