Re: First release of ly/tablature.ly

[Carl D. Sorensen]

Thanks, Joe.

On 6/23/09 12:31 PM, "address@hidden" <address@hidden> wrote:

> I don't know much about the issues here, but here's a review, fwiw. Of
> course, you'll need to update the docs also (and a regression test or 2
> would be nice).

Yep, docs and regressions are in the works.  (Although Graham says that docs
aren't the developers' responsibility).

> 
> 
> http://codereview.appspot.com/67174/diff/1/2
> File ly/tablature.ly (right):
> 
> http://codereview.appspot.com/67174/diff/1/2#newcode205
> Line 205: tabFullNotation = {
> Why not create a new context, FullTabVoice, or something like that? Do
> you expect people to use \tabFullNotation mid-piece?

Marc originally went for a new context.  But we don't have different Voice
or Staff contexts when we change how notes are displayed.  So I don't think
we should have different TabVoice or TabStaff contexts when we change how
TabNotes are displayed.

> 
> http://codereview.appspot.com/67174/diff/1/2#newcode237
> Line 237: \layout {
> It seems to me that we have 3 versions of tablature now: the "default"
> version in engraver-init.ly, the version that appears if the user
> includes "tablature.ly" and the "full" version that the user gets by
> including tablature.ly and using the tabFullNotation. Is there a reason
> for keeping the old versions in engraver-init.ly? Perhaps we should
> scrap them altogether and require that the user include tablature.ly in
> order to get tabs.

The current structure comes because I suggested we keep the default the
same, so that we wouldn't break all of the existing tablatures.  But Marc
wanted to have TabNumbersOnly be the default (and that's why it's
implemented that way in tablature.ly).

The tabFullNotation is probably almost the same as that in engraver-init.ly.

If we don't mind breaking previously existing scores, then we can go ahead
and change the initialization to numbers only.

> 
> http://codereview.appspot.com/67174


Thanks again,

Carl