lilypond-devel
[Top][All Lists]

## Re: [PATCH v3] Fix crash when a stencil routine is missing

 From: Patrick McCarty Subject: Re: [PATCH v3] Fix crash when a stencil routine is missing Date: Wed, 15 Jul 2009 21:49:51 -0700

On Tue, Jul 7, 2009 at 2:44 PM, Patrick McCarty<address@hidden> wrote:
> Hello,
>
> The third revision of my patch set (Patch Set 5) is on Rietveld:
>
> http://codereview.appspot.com/83046/show
>
> The change from Patch Set 4 is the generalization of
> -dwarning-as-error.  Note that this is a series of 8 commits that
> contain more in-depth commit summaries.  They can be found here:
>

Does anyone have comments for these changes?

Really, there are four separate changes:

1) Removing obsolete code from lily.scm and output-ps.scm.
2) Enabling warnings for missing stencil expressions.  Currently,
Guile crashes in these cases.
3) Revision of define-stencil-commands.scm so that it makes more sense.
4) Adding a new option, -dwarning-as-error, that turns all warnings
into errors if enabled.

IMO, 1) and 3) are completely harmless.  I'm not entirely sure if I
used the best approach for 2) or 4).