[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New instrument name positioning in Scheme.

From: n . puttock
Subject: Re: New instrument name positioning in Scheme.
Date: Thu, 16 Jul 2009 22:51:26 +0000

Reviewers: joeneeman,

On 2009/07/16 05:52:35, joeneeman wrote:
Just one corner case, otherwise lgtm

Thanks, Joe.

I'll add a convert-ly rule for ly:system-start-text::print, a regtest
and NEWS entry before pushing.
File scm/output-lib.scm (right):
Line 833: (interval-center extent))))
If (not (pair? live-elts)) then (interval-center extent) will be NaN,
instead of
0 which would be more sensible.

That's caught by interval-center, since it returns 0.0 for empty

New instrument name positioning in Scheme.

* remove x/y positioning from print callback to separate X- and Y-offset
* add x-offset calculation for system start delimeter extents so all
  instrument names in a system are aligned correctly based on
* use 'when from left-bound instead of get_break_index () to determine
  which text to print; this fixes incorrect indentation and text for
  shortInstrumentName overrides (Issue #452)
* remove acknowledger for system-start-text from
* remove
* add system-start-text-interface to define-grob-interfaces.scm
* add library functions used by new callbacks to lily-library.scm
  and output-lib.scm

Please review this at

Affected files:
  M input/lsr/
  A input/new/
  M input/regression/
  M lily/
  M lily/
  M scm/define-grob-interfaces.scm
  M scm/define-grobs.scm
  M scm/lily-library.scm
  M scm/output-lib.scm

reply via email to

[Prev in Thread] Current Thread [Next in Thread]