[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New markup commands: \left-brace & \right-brace.

From: Carl . D . Sorensen
Subject: Re: New markup commands: \left-brace & \right-brace.
Date: Fri, 17 Jul 2009 01:40:05 +0000

Code looks good to me.

I have a couple of optional minor nitpicks.


File scm/define-markup-commands.scm (right):
Line 2623: (ly:font-get-glyph font (string-append "brace"
(number->string n)))))
Do we want to keep line length to <80 chars?
File scm/lily-library.scm (right):
Line 555: "Find the index between START and END (an integer) which
Use @var{start} instead of START ?
Use (_i "docstring") to allow internationalization?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]