[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: more code-cleanup patches

From: Neil Puttock
Subject: Re: more code-cleanup patches
Date: Sun, 19 Jul 2009 17:32:34 +0100

2009/7/19 Mark Polesky <address@hidden>:
> Are these two patches okay to apply?


> Starting on line 845 in define-grob-properties.scm, there is a group
> labeled "grobs & grob arrays", and of the 60 or so properties there, all
> of them have type ly:grob or ly:grob-array, except the following nine.
> Should these nine properties be moved to the section labeled "other"
> starting on line 951?

I would leave these two since they involve lists of grobs:

>     (accidental-grobs ,list? "An alist with @code{(@var{notename} .
> @var{groblist})} entries.")

>     (note-columns ,pair? "A list of @code{NoteColumn} grobs.")

You can move the following to user properties, since it is
user-serviceable (as shown by Marc's new tablature implementation):

>     (glyph-name ,string? "The glyph name within the font.")

I'm fine with moving the rest.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]