[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New format for autobeaming rules

From: n . puttock
Subject: Re: New format for autobeaming rules
Date: Wed, 22 Jul 2009 23:23:04 +0000
File input/new/ (right):
Line 7: Beaming patterns may be altered with the @code{beatGrouping}
new texidoc using \overrideBeamSettings
File lily/ (right):
Line 10: #include "beam-grouping.hh"
Line 26: " @var{rule-type} in @var{context}.")
no context arg, doc settings
Line 28: LY_ASSERT_TYPE (ly_is_pair, time_signature, 2);
Line 30:
type check also for settings?
Line 34: ly_assoc_get ((scm_list_2 (time_signature, rule_type)),
excess parens
Line 43: "Return grouping for beams of @var{ beam-type} in"
Line 45: " @var{rule-type} in @var{context}.")
no context arg, doc settings
Line 46: {
type checks?
Line 57: {
LY_ASSERT_SMOB (Context, context, 1);

If you don't do this, then unsmob_context () will return NULL if this
function is passed invalid arguments, leading to a null dereference for
get_property ("timeSignatureFraction") -> segfault
File lily/ (right):
Line 18: #include "beam-grouping.hh"
File lily/include/beam-grouping.hh (right):
Line 8:
To prevent multiple includes:


(+ line 14)
Line 14:
File lily/ (right):
Line 14: #include "beam-grouping.hh"
Line 66: SCM time_signature_fraction = get_property
move to if { } block, then it's only retrieved if required
File ly/ (right):
Line 20: (_i "Define @@var{music} as a quotable music expression named
rogue extra @'s throughout file
File python/ (right):
Line 2930: str = re.sub("\\set\w+#\'beatGrouping", "\\setBeatGrouping",
won't get here due to search above (and regexp is broken)
File scm/beam-settings.scm (right):
Line 48: ;; in 3 4 time:
decided not to restore original setting?
Line 155: ;;;; Functions for overriding beam settings
indentation of function bodies
File scm/define-context-properties.scm (right):
Line 126: (beatGrouping ,list? "A list of beatgroups, e.g., in 5/8 time

reply via email to

[Prev in Thread] Current Thread [Next in Thread]