[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: feature-request / doc-actualization (right-margin)

From: Neil Puttock
Subject: Re: [PATCH] Re: feature-request / doc-actualization (right-margin)
Date: Tue, 11 Aug 2009 23:56:36 +0100

2009/8/11 Michael Käppler <address@hidden>:

> here is the first draft of a patch concerning the margin settings for
> review.

Some comments:

+           "Checks whether @code{left-margin}, @code{right-margin}
and @code{line-width)"


This and the following docstring lines are too long.

+  Real paper_width = scm_to_double (lookup_variable (ly_symbol2scm

+  Real left_margin_default = scm_to_double (lookup_variable
(ly_symbol2scm ("left-margin-default")));

+  Real right_margin_default = scm_to_double (lookup_variable
(ly_symbol2scm ("right-margin-default")));

These are unsafe, since they return SCM_UNSPECIFIED instead of a Real
if the paper variables aren't defined; using robust_scm2double () here
will ensure a default is returned.

You can see the consequences of variable lookup failure by running 
 This snippet also fails to get a sane value for paper-height in


reply via email to

[Prev in Thread] Current Thread [Next in Thread]