|
From: | Michael Käppler |
Subject: | Re: [PATCH] Implement new handling for margin and line-width settings. |
Date: | Wed, 12 Aug 2009 19:15:45 +0200 |
User-agent: | Thunderbird 2.0.0.12 (X11/20071114) |
Hi Carl,
Sorry, that wasn't intended. It was late yesterday and I didn't notice I pressed the wrong button... ;)Usually we like to keep responses to reviews on the -devel list, so I've copied this there.
Oh -- I misunderstood the meaning of the FIXME. I think I'd recommend changing the settings to something that is rational. Since we're using the changed settings, we might as well change them so we don't keep getting errors.
Am I right you suggest to modify the output-def just once but permanent?
I still think my suggestion for avoiding the variable consistency is a good one. I have very rough pseudocode below
Done.
What do you want to achieve by this? I don't really like the idea of mixing variables set in \paper {} with computed values from normalize (). The only aim of normalize () is to add missing values (although this isn't needed in some cases, e.g. right-margin is never used elsewhere) and set default values if the settings are considered bad. What I would like to add is the possibility to switch off this "consistency check", so that you can have negative margins and exceeding line-widths if you need to.You could even be smarter in your choice of margins and line-widths to set. For example, if left_margin > 0 and right_margin <0, you could do set_paper_layout (left_margin, line_width + right_margin, 0) or something like that.
Regards, Michael
[Prev in Thread] | Current Thread | [Next in Thread] |