|
From: | Trevor Daniels |
Subject: | Re: [PATCH] Extended documentation on Turkish classical music and makam |
Date: | Thu, 3 Sep 2009 19:23:52 +0100 |
Hi Joe, you wroteThursday, September 03, 2009 10:35 AM
Trevor Daniels wrote:I then looked at the actual mail message. You're using Thunderbird with inline attachments and quoted-printable encoding. This is the problem. I seem to remember Jonathan Kulp discovering that Thunderbird messed up the line endings of patches. I'm not familiar with Thunderbird. Are you able to set it up with a different content-disposition, maybe something to send a file as binary, ie unmolested? If not, do you have access to another mailer?I searched around for some info on this and think I've found the correct way to set up Thunderbird.I've attached a patch that implements Graham's requested corrections; I'll follow up with another to add the Turkish accidentals to the table in pitches.itely. I would have taken a little longer and done both together, but I want to check if the new email setup is working.
'Fraid it isn't. The patch still had DOS endings. But it applied cleanly
after I changed them. It's now pushed to origin/master. Using "Content-Type: multipart/mixed;" is good, but the encoding of "Content-Transfer-Encoding: 7bit" looks suspicious. Can this be changed?
If it is, I'll add a note to the contributor's guide describing how to set up Thunderbird.
We're not quite there yet, but definitely do this once we are :) Trevor
[Prev in Thread] | Current Thread | [Next in Thread] |